Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check installed dependents on install and reinstall #7880

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Check installed dependents on install and reinstall #7880

merged 1 commit into from
Jul 2, 2020

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jul 2, 2020 •
edited

It's not sufficient to do this merely on brew upgrade because brew install and brew reinstall can also result in formulae being upgraded.

This requires moving logic from cmd/upgrade.rb to upgrade.rb. To save you searching the diff the changes that resulted from doing that:

  • Query the installed formulae from class state in FormulaInstaller rather than the (incomplete) list that we passed into it.
  • Don't output the "Checking dependents" message. It was there for systems and configurations where this is slow but for most users and most installations this will be a (annoying, noisy) no-op.

Fixes #7860

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid MikeMcQuaid mentioned this pull request Jul 2, 2020
Closed
3 tasks
@MikeMcQuaid
Check installed dependents on install and reinstall
2c133a3 
It's not sufficient to do this merely on `brew upgrade` because
`brew install` and `brew reinstall` can also result in formulae being
upgraded.

This requires moving logic from `cmd/upgrade.rb` to `upgrade.rb`. To
save you searching the diff the changes that resulted from doing that:

- Query the installed formulae from class state in `FormulaInstaller`
  rather than the (incomplete) list that we passed into it.
- Don't output the "Checking dependents" message. It was there for
  systems and configurations where this is slow but for most users
  and most installations this will be a (annoying, noisy) no-op.

Fixes #7860
@MikeMcQuaid MikeMcQuaid force-pushed the check_dependents_install_reinstall branch from 1df12fb to 2c133a3 Compare July 2, 2020 11:53
@MikeMcQuaid MikeMcQuaid merged commit 9fc0799 into Homebrew:master Jul 2, 2020
@MikeMcQuaid MikeMcQuaid deleted the check_dependents_install_reinstall branch July 2, 2020 12:30
@karlhorky
Copy link

Awesome, cheers for this @MikeMcQuaid! 🚀

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 26, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

brew install without brew upgrade can cause broken packages
3 participants
@MikeMcQuaid @karlhorky @BrewTestBot